-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenDroneMap to docker compose stack #116
Conversation
It could have been better if the odm related compose are in the seperate compose file like |
Yeah for sure I can do that 👍 |
Done. Now to run only ODM: docker compose -f docker-compose.odm.yml up -d or to run it alongside Drone TM: docker compose -f docker-compose.yml -f docker-compose.odm.yml up -d |
Although in my opinion, these should be merged back together in future, as we use the main The |
Yes, you are right. But, we could use the above command too. |
I commented on the discussion here about this topic: #94 Probably best we have a call at some point to discuss this. For the POC using locally hosted Minio (essentially storing all images on-disk with an S3 wrapper) is probably ok, but we need large storage attached to the machine we deploy to. S3 is still the way to go in the future, but probably an externally hosted one. ODM does not support bulk file import from S3 though. To import in bulk via the NodeODM API we would need to zip the files first |
7c99587
to
6feee83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setup went smooth! I think it's fine to keep ODM in separate compose file as users may want to use their own ODM stack. Optionally, they will have option to run ODM via compose stack too. IMO: It's better to provide docs to run ODM via compose stack rather than merging it in default. But if the requirement/convention goes as "the project should run with just docker compose up
", Its fine to bake into default compose file too.
Adds the following:
ODMWeb (UI) --> worker/broker --> ODM API (processing)